I wonder if someone can assist with this dilemma...
I have a wonderful tango teacher who is fantastic at teaching.
But the huge problem is that he undermines my confidence somewhat.
Should I look past that or not?
Absolutely agree. One of the most important facets in tango is confidence. If your teacher is not helping there, they are a bad teacher. In fact if they are eroding your confidence I would say they are doing more bad than good!!!!!!